Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin opentelemetry dependency versions #745

Merged
merged 4 commits into from
Jul 1, 2023
Merged

chore: pin opentelemetry dependency versions #745

merged 4 commits into from
Jul 1, 2023

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Jun 30, 2023

It seems OpenTelemetry JS is changing @opentelemetry/instrumentation pre-1.0 minor versions in instrumentation packages patch versions.

This can cause multiple @opentelemetry/instrumentation packages to appear under dependencies. Each has its own RequireInTheMiddleSingleton hooking into all of the require calls, causing slow application starts.

I've pinned the deps such that only one @opentelemetry/instrumentation package - 0.35.1 is installed now.

@seemk seemk requested review from a team as code owners June 30, 2023 21:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c469a65) 88.41% compared to head (7f939c7) 88.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #745   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          28       28           
  Lines        1278     1278           
  Branches      286      286           
=======================================
  Hits         1130     1130           
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seemk seemk merged commit f98a9b6 into main Jul 1, 2023
@seemk seemk deleted the pin-otel-deps branch July 1, 2023 10:08
@seemk seemk mentioned this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants