Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add Node 22 to prebuilds and unit tests #963

Merged
merged 6 commits into from
Oct 29, 2024
+29 −20
Merged

CI: Add Node 22 to prebuilds and unit tests #963

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6e4c7a
add node 22 and 23 to ci
seemk Oct 29, 2024
720d403
update deps
seemk Oct 29, 2024
35599b2
upgrade binding cppstd version logic for node 23
seemk Oct 29, 2024
9a1f88e
drop node23 from ci
seemk Oct 29, 2024
7cc9728
use setup-node v4
seemk Oct 29, 2024
29274b6
use setup-node v3 and node 22.10 for windows unit tests
seemk Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
drop node23 from ci
@seemk
seemk committed Oct 29, 2024
commit 9a1f88efc8e2e04ef206e9acf972d89a8b4a7567
12 changes: 3 additions & 9 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -23,8 +23,6 @@ jobs:
node_api_target: '21.2.0'
- container: 'node:16.0.0'
node_api_target: '22.0.0'
- container: 'node:16.0.0'
node_api_target: '23.0.0'
container: ${{ matrix.container }}
steps:
- name: Checkout
@@ -53,8 +51,6 @@ jobs:
node_api_target: '21.2.0'
- container: 'node:16.0.0'
node_api_target: '22.0.0'
- container: 'node:16.0.0'
node_api_target: '23.0.0'
container: ${{ matrix.container }}
steps:
- name: Checkout
@@ -75,7 +71,7 @@ jobs:
fail-fast: false
matrix:
os: [windows-2019, macos-12]
node_api_target: ['14.0.0', '15.0.0', '16.0.0', '17.0.1', '18.0.0', '20.0.0', '21.2.0', '22.0.0', '23.0.0']
node_api_target: ['14.0.0', '15.0.0', '16.0.0', '17.0.1', '18.0.0', '20.0.0', '21.2.0', '22.0.0']
include:
- os: macos-12
python_version: '3.11'
@@ -139,7 +135,7 @@ jobs:
fail-fast: false
matrix:
os: ['ubuntu-latest', 'macos-latest']
nodejs: ['14', '16', '17', '18', '20', '21', '22', '23']
nodejs: ['14', '16', '17', '18', '20', '21', '22']
exclude:
- os: 'macos-latest'
nodejs: '14'
@@ -163,8 +159,6 @@ jobs:
nodejs: '21.7.2'
- os: 'windows-2019'
nodejs: '22.0.0'
- os: 'windows-2019'
nodejs: '23.0.0'
steps:
- name: Checkout
uses: actions/checkout@v3
@@ -190,7 +184,7 @@ jobs:
fail-fast: false
matrix:
os: ['ARM64']
nodejs: ['14', '16', '17', '18', '20', '21', '22', '23']
nodejs: ['14', '16', '17', '18', '20', '21', '22']
container: node:${{ matrix.nodejs }}
steps:
- name: Checkout