Skip to content

Commit

Permalink
Add layout prop to RoomSession.play() (#562)
Browse files Browse the repository at this point in the history
* add missing layout prop

* add changeset
  • Loading branch information
framini authored Jun 10, 2022
1 parent bfbb670 commit 02d97de
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 1 deletion.
7 changes: 7 additions & 0 deletions .changeset/hip-moose-perform.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@signalwire/core': minor
'@signalwire/js': minor
'@signalwire/realtime-api': minor
---

Add `layout` property to RoomSession.play()
1 change: 1 addition & 0 deletions packages/core/src/rooms/methods.ts
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ export type PlayParams = {
url: string
volume?: number
positions?: Record<string, VideoPosition>
layout?: string
}
export const play: RoomMethodDescriptor<any, PlayParams> = {
value: function (params) {
Expand Down
4 changes: 4 additions & 0 deletions packages/js/src/RoomSession.docs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,10 @@ interface RoomControlMethodsInterfaceDocs {
* special keywork `self` to refer to the id of the playback.
*/
positions?: VideoPositions
/**
* Layout to change to for the duration of the playback.
*/
layout?: string
}): Promise<Rooms.RoomSessionPlayback>

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/realtime-api/src/video/RoomSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,10 @@ interface RoomSessionDocs extends RoomSessionMain {
* special keywork `self` to refer to the id of the playback.
*/
positions?: VideoPositions
/**
* Layout to change to for the duration of the playback.
*/
layout?: string
}): Promise<Rooms.RoomSessionPlayback>

/**
Expand Down Expand Up @@ -586,7 +590,7 @@ export interface RoomSession
extends AssertSameType<RoomSessionMain, RoomSessionDocs> {}

export type RoomSessionUpdated = EntityUpdated<RoomSession>
export interface RoomSessionFullState extends Omit<RoomSession, "members"> {
export interface RoomSessionFullState extends Omit<RoomSession, 'members'> {
/** List of members that are part of this room session */
members?: RoomSessionMember[]
}
Expand Down

0 comments on commit 02d97de

Please sign in to comment.