Fix member.updated events (#885)

* strip namespace prefix from member.updated event * changeset * update tests * rm debug
signalwire · Sep 20, 2023 · bcced8a · bcced8a
1 parent e5db7ca
commit bcced8a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 14 deletions.
diff --git a/.changeset/long-timers-rhyme.md b/.changeset/long-timers-rhyme.md
@@ -0,0 +1,5 @@
+---
+'@signalwire/core': patch
+---
+
+Bugfix: remove video prefix from member.updated events to emit them properly
diff --git a/packages/core/src/memberPosition/workers.test.ts b/packages/core/src/memberPosition/workers.test.ts
@@ -88,17 +88,14 @@ describe('memberPositionWorker', () => {
       .run()
       .finally(() => {
         expect(emitSpy).toHaveBeenCalledWith(
-          'video.member.updated.visible',
+          'member.updated.visible',
           action.payload
         )
         expect(emitSpy).toHaveBeenCalledWith(
-          'video.member.updated.video_muted',
-          action.payload
-        )
-        expect(emitSpy).toHaveBeenCalledWith(
-          'video.member.updated',
+          'member.updated.video_muted',
           action.payload
         )
+        expect(emitSpy).toHaveBeenCalledWith('member.updated', action.payload)
         expect(memberList.get(memberId)?.member.visible).toBe(true)
         expect(memberList.get(memberId)?.member.video_muted).toBe(false)
         expect(memberList.get(memberId)?.member.updated).toStrictEqual([

diff --git a/packages/core/src/memberPosition/workers.ts b/packages/core/src/memberPosition/workers.ts
@@ -5,6 +5,7 @@ import {
   SagaIterator,
   SDKWorker,
   SDKWorkerParams,
+  stripNamespacePrefix,
   VideoMemberUpdatedEventParams,
   VideoPosition,
   VideoRoomSubscribedEventParams,
@@ -60,7 +61,7 @@ function* memberPositionLayoutChangedWorker(options: any) {
 
   for (const [memberId, payload] of memberList) {
     if (processedMembers[memberId]) {
-      yield dispatcher?.('video.member.updated', payload, instance)
+      yield dispatcher?.('member.updated', payload, instance)
 
       /**
        * `undefined` means that we couldn't find the
@@ -78,11 +79,7 @@ function* memberPositionLayoutChangedWorker(options: any) {
         return
       }
 
-      yield dispatcher?.(
-        'video.member.updated',
-        updatedMemberEventParams,
-        instance
-      )
+      yield dispatcher?.('member.updated', updatedMemberEventParams, instance)
     }
   }
 }
@@ -121,12 +118,13 @@ export function* memberUpdatedWorker({
   /** member.updated event is the only one updating the memberList payload */
   memberList.set(memberId, memberUpdatedPayload)
 
+  const event = stripNamespacePrefix(action.type)
   for (const key of updated) {
-    const type = `${action.type}.${key}` as InternalMemberUpdatedEventNames
+    const type = `${event}.${key}` as InternalMemberUpdatedEventNames
     yield dispatcher?.(type, memberUpdatedPayload, instance)
   }
 
-  yield dispatcher?.(action.type, memberUpdatedPayload, instance)
+  yield dispatcher?.(event, memberUpdatedPayload, instance)
 }
 
 export const MEMBER_POSITION_COMPOUND_EVENTS = new Map<any, any>([