Prevent verto RPCs without node_id (#461)

* add checks for bad cases between invite and hangup

* remove check for undocumented methods

* add changeset

.changeset/many-planets-hope.md

@@ -0,0 +1,5 @@
+---
+'@signalwire/webrtc': patch
+---
+
+Prevent BaseConnection RPCs without a `node_id`.

packages/webrtc/src/BaseConnection.ts

@@ -210,7 +210,7 @@ export class BaseConnection<EventTypes extends EventEmitter.ValidEventTypes>
  * Verto messages have to be wrapped into an execute
  * request and sent using the 'video.message' method.
  */
- public vertoExecute(vertoMessage: JSONRPCRequest) {
+ private vertoExecute(vertoMessage: JSONRPCRequest) {
  const params: any = {
  message: vertoMessage,
  node_id: this.nodeId,
@@ -225,6 +225,14 @@ export class BaseConnection<EventTypes extends EventEmitter.ValidEventTypes>
  } else {
  params.subscribe = this.getSubscriptions()
  }
+ } else {
+ // nodeId is required for all the requests (except for verto.invite)
+ if (!this.nodeId) {
+ this.logger.warn(
+ `Skip Request. Missing nodeId for '${vertoMessage.method}'.`
+ )
+ return
+ }
  }
 
  return this.execute({
@@ -539,6 +547,15 @@ export class BaseConnection<EventTypes extends EventEmitter.ValidEventTypes>
 
  /** @internal */
  async executeInvite(sdp: string) {
+ if (this.state !== 'new') {
+ /**
+ * Something bad happened. Either App logic invoking
+ * methods in a wrong order or events are not correct.
+ */
+ throw new Error(
+ `Invalid state: '${this.state}' for connection id: ${this.id}`
+ )
+ }
  this.setState('requesting')
  try {
  const ssOpts = this.options.screenShare