Fix testMatch on e2e-js (#713)

* remove testMatch from playwright config and remove the ignore

* fix roomSessionPromoteParticipant.spec.ts to check for 202 instead of 403

* accept 202 as valid response code

* update check on promote

* changeset

.changeset/six-pets-eat.md

@@ -0,0 +1,5 @@
+---
+'@signalwire/core': patch
+---
+
+Accept 202 as valid response code

internal/e2e-js/playwright.config.ts

@@ -7,7 +7,6 @@ const config: PlaywrightTestConfig = {
  globalSetup: require.resolve('./global-setup'),
  // testMatch: ['roomSessionStreamingAPI.spec.ts'],
  testIgnore: [
- 'roomSessionPromoteParticipant.spec.ts',
  // 'roomSessionStreaming.spec.ts',
  ],
  timeout: 120_000,

internal/e2e-js/tests/roomSessionPromoteParticipant.spec.ts

@@ -7,8 +7,8 @@ import {
  SERVER_URL,
 } from '../utils'
 
-test.describe('RoomSession promote method', () => {
- test('should not be able to promote participant', async ({ context }) => {
+test.describe('RoomSession promote myself', () => {
+ test('should get 202 on trying to promote a member', async ({ context }) => {
  const pageOne = await context.newPage()
  enablePageLogs(pageOne, '[pageOne]')
 
@@ -47,21 +47,20 @@ test.describe('RoomSession promote method', () => {
  await pageOne.waitForTimeout(2000)
 
  // --------------- Promote participant from pageOne and resolve on error ---------------
- const errorCode: any = await pageOne.evaluate(async () => {
+ const promoteResponse: any = await pageOne.evaluate(() => {
  // @ts-expect-error
  const roomObj: Video.RoomSession = window._roomObj
 
- const error = await roomObj
+ return roomObj
  .promote({
  memberId: roomObj.memberId,
  permissions: ['room.member.promote', 'room.member.demote'],
  })
- .catch((error) => error)
- console.log('promote error', error.jsonrpc.code, error.jsonrpc.message)
- return error.jsonrpc.code
+ .then(() => true)
+ .catch(() => false)
  })
 
- expect(errorCode).toBe('403')
+ expect(promoteResponse).toBe(true)
 
  // --------------- Leaving the rooms ---------------
  // @ts-expect-error

packages/core/src/utils/parseRPCResponse.ts

@@ -23,6 +23,8 @@ export const parseRPCResponse = ({
  }
 }
 
+const SUCCESS_CODES = ['200', '202']
+
 /**
  * From the socket we can get:
  * - JSON-RPC msg with 1 level of 'result' or 'error'
@@ -40,7 +42,7 @@ const parseResponse = (
  return { error }
  }
  const { code, node_id, result: nestedResult = null } = result
- if (code && code !== '200') {
+ if (code && !SUCCESS_CODES.includes(code)) {
  return { error: result }
  }
  if (nestedResult === null) {