Playback APIs #297
Merged
Playback APIs #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e3c710e The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edolix
force-pushed
the
eg/playback-apis
branch
2 times, most recently
from
4dcfacf
to
6316fb8
Compare
edolix
force-pushed
the
eg/playback-apis
branch
from
84e51d0
to
6c79223
Compare
edolix
force-pushed
the
eg/playback-apis
branch
from
6c79223
to
de257d8
Compare
edolix
commented
Oct 5, 2021
Comment on lines
+136
to
+138
| transformResolve: (payload) => ({ | ||
| recordings: payload.recordings.map((row) => toExternalJSON(row)), | ||
| }), |
There was a problem hiding this comment.
Note for @danieleds - we are transforming the properties from snake_case to camelCase here (and same for playbacks on L171 below)
danieleds
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startPlaybackwithplay(or other method name)realtime-api