Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow the js SDK to be used in the Shadow DOM #497

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

edolix
Copy link
Contributor

@edolix edolix commented Apr 11, 2022

The idea is not rely on document.* APIs (= document.getElementById) to have the SDK works within the Shadow DOM.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2022

🦋 Changeset detected

Latest commit: 14c3bd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@signalwire/js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edolix edolix requested a review from framini April 11, 2022 12:49
@edolix edolix changed the title WIP: Fix to allow the js SDK to be used in the Shadow DOM Fix to allow the js SDK to be used in the Shadow DOM Apr 11, 2022
@edolix edolix merged commit 1fcf254 into main Apr 12, 2022
@edolix edolix deleted the eg/fix-usage-in-shadow-dom branch April 12, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants