Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jest/Babel #523

Merged
merged 3 commits into from
May 2, 2022
Merged

Upgrade Jest/Babel #523

merged 3 commits into from
May 2, 2022

Conversation

framini
Copy link
Contributor

@framini framini commented May 2, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4a5f220

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

framini
framini commented May 2, 2022
View reviewed changes
package.json
"concurrently": "^6.5.1",
"esbuild": "0.14.38",
"jest": "^27.5.1",
"jest": "^28.0.3",
"jest-environment-jsdom": "^28.0.2",
Copy link
Contributor Author

@framini framini May 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest 28 no longer comes with jest-environment-jsdom so it has to be included manually. https://jestjs.io/docs/upgrading-to-jest28#jsdom

@framini framini requested a review from edolix May 2, 2022 09:34
framini
framini commented May 2, 2022
View reviewed changes
packages/js/jest.config.js
@@ -2,4 +2,5 @@ module.exports = {
transform: {
'\\.[jt]sx?$': ['babel-jest', { configFile: './../../babel.config.js' }],
},
resolver: '<rootDir>/test/resolver.js',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jestjs.io/docs/upgrading-to-jest28#packagejson-exports

Known examples of packages that fails in Jest 28 are uuid and nanoid when using the jest-environment-jsdom environment. For an analysis, and a potential workaround, see this comment.

@edolix edolix merged commit f1f8472 into main May 2, 2022
@edolix edolix deleted the fr/upgrade-jest branch May 2, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolix edolix edolix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@framini @edolix