Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining usages of old api for running workers #546

Merged
merged 6 commits into from
May 27, 2022

Conversation

framini
Copy link
Contributor

@framini framini commented May 25, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2022

🦋 Changeset detected

Latest commit: 599ba6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@signalwire/core Patch
@signalwire/js Patch
@signalwire/realtime-api Patch
@signalwire/react-native Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@framini framini changed the title WIP: migrate remaining usages of old api for running workers Migrate remaining usages of old api for running workers May 25, 2022
@framini framini requested a review from edolix May 25, 2022 11:50
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove setWorker/attachWorkers from BaseComponent too?

@edolix edolix merged commit fc4689d into main May 27, 2022
@edolix edolix deleted the fr/worker-api-mig branch May 27, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants