Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with join_video/audio_muted and local streams + type fixes #554

Merged
merged 5 commits into from
Jun 1, 2022

Conversation

framini
Copy link
Contributor

@framini framini commented Jun 1, 2022

The code in this changeset includes:

  • Fix issue with local stream being active when the user joined with join_video_muted: true or join_audio_muted: true
  • Fix typing for meta (it's marked as optional on the BE)
  • Added members to VideoRoomSessionContract and made it optional in RoomSessionFullState for realtime-api

@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: 7ff461d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@signalwire/core Patch
@signalwire/js Patch
@signalwire/realtime-api Patch
@signalwire/react-native Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@framini framini requested a review from edolix June 1, 2022 10:39
@edolix edolix merged commit 1b95b93 into main Jun 1, 2022
@edolix edolix deleted the fr/local-muted branch June 1, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants