Realtime-API - expose methods to retrieve room sessions #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd8d982 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edolix
changed the title
framini
reviewed
Jun 24, 2022
| @@ -81,6 +89,58 @@ class VideoAPI extends BaseConsumer<RealTimeVideoApiEvents> { | |||
| ], | |||
| ]) | |||
| } | |||
|
|
|||
| async getRoomSessionsInProgress() { | |||
There was a problem hiding this comment.
Not sure I understand the need of the suffix InProgress here?
framini
previously approved these changes
Jun 24, 2022
danieleds
reviewed
Jun 24, 2022
Comment on lines
+38
to
+40
|
|
||
| getRoomSessions(): Promise<{ roomSessions: RoomSession[] }> | ||
| getRoomSessionById(id: string): Promise<{ roomSession: RoomSession }> |
There was a problem hiding this comment.
@edolix are these the only changes in the public interface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new methods in realtime-api to get list of room_sessions and and retrieve by id.
TODO