Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve auto-subscribe logic #596

Merged
merged 10 commits into from
Jul 26, 2022
Merged

Improve auto-subscribe logic #596

merged 10 commits into from
Jul 26, 2022

Conversation

edolix
Copy link
Contributor

@edolix edolix commented Jul 21, 2022 •
edited
Loading

  • Auto-adjust PubSub subscriptions in case the end-user invoked .subscribe before .on/.once
  • Enhance auto-subscribe pattern on VideoClient
  • Add e2e tests in JS for PubSub
  • Add PubSub example in playground-js

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 90ed366

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@signalwire/core Patch
@signalwire/realtime-api Patch
@sw-internal/e2e-js Patch
@sw-internal/playground-js Patch
@signalwire/js Patch
@signalwire/react-native Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edolix edolix requested a review from framini July 21, 2022 10:17
@edolix edolix changed the title WIP: Improve auto-subscribe logic Improve auto-subscribe logic Jul 22, 2022
framini
framini approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@framini framini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@edolix edolix merged commit 6bc89d8 into main Jul 26, 2022
@edolix edolix deleted the eg/fix-subscribe-no-events branch July 26, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@framini framini framini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edolix @framini