Update types for RoomSession/Member/Layout/Playback #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2dd5003 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
framini
force-pushed
the
fr/interface-updates
branch
from
14645d8
to
3b2ff4c
Compare
framini
changed the title
edolix
reviewed
Aug 12, 2022
| @@ -342,4 +342,233 @@ test.describe('RoomSession', () => { | |||
| expect(targetElementsCount.videos).toBe(0) | |||
| expect(targetElementsCount.rootEl).toBe(0) | |||
| }) | |||
|
|
|||
| test(`should allow retrieving the room session recordings and playbacks`, async ({ | |||
edolix
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoRoomSessionContractRoomSession.membersin favour ofRoomSession.getMembersRoomSession.recordingsin favour ofRoomSession.getRecordingsRoomSession.getRecordingsto return instances ofRoomSessionRecordingRoomSession.getPlaybacksto return instances ofRoomSessionPlaybackVideoMemberContracton_hold: we had it on the SDK but it doesn’t seem to come over the wire nor is in the spec.VideoPlaybackContractpositionpropertyVideoLayoutLayerplaying_fileandvisibleproperties