Resize aspect-ratio / padding to fix video overflow #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 75b5ba4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LittorWired
commented
Sep 6, 2022
LittorWired
commented
Sep 6, 2022
LittorWired
commented
Sep 6, 2022
LittorWired
commented
Sep 6, 2022
LittorWired
commented
Sep 7, 2022
edolix
changed the title
LittorWired
commented
Sep 8, 2022
Comment on lines
+181
to
+189
| const getWX = () => { | ||
| const nativeVideoRatio = video.videoWidth / video.videoHeight | ||
| const clientSideRatio = rootElement.clientWidth / rootElement.clientHeight | ||
| if (nativeVideoRatio > clientSideRatio) { | ||
| return { width: '100%' } | ||
| } else { | ||
| return { width: `${rootElement.clientHeight * nativeVideoRatio}px` } | ||
| } | ||
| } |
There was a problem hiding this comment.
Here we calculate a proportion of the native video element (resolution) to the parent container and use this to calculate the width need to move the mcuLayers to correct position i.e overlay the user's local video onto the video from the stream.
edlucas
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the browser viewport is at an aspect ratio where a vertical scrollbar is introduced, the bottom bar is positioned at the bottom of the viewport. Upon scrolling down, the footer keeps that position, which is now in the middle of the content.