Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing getters to CallRecording #834

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

edolix
Copy link
Contributor

@edolix edolix commented Jul 20, 2023

Description

Review internal interfaces/contracts for TS and fix missing getters in CallRecording.

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

Not required

@edolix edolix requested review from danieleds and iAmmar7 July 20, 2023 19:32
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

🦋 Changeset detected

Latest commit: 3a8b6d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@signalwire/core Patch
@signalwire/realtime-api Patch
@signalwire/js Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edolix edolix merged commit 81beb29 into main Jul 21, 2023
10 of 11 checks passed
@edolix edolix deleted the eg/review-rt-api-interfaces branch July 21, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants