Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand raise API for the video SDK #873

Merged
merged 14 commits into from
Nov 10, 2023
Merged

Hand raise API for the video SDK #873

merged 14 commits into from
Nov 10, 2023

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented Sep 5, 2023

Description

Implement the hand raise APIs for the Video SDKs (browser and realtime)

ref: https://github.com/signalwire/cloud-product/issues/7901

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In the browser SDK

await room.setRaisedHand({
    memberId: "1234....", // Optional
    raised: false,  // Optional. Default is true
})

await room.setPrioritizeHandraise(false)

In the realtime SDK

await room.setRaisedHand({
    memberId: "1234....", // Mandatory
    raised: false,  // Optional. Default is true
})

await room.setPrioritizeHandraise(true)

await member.setRaisedHand({ raised: false }) // Optional param. Default it true

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 48911e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@signalwire/realtime-api Minor
@signalwire/core Minor
@signalwire/js Minor
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7
Copy link
Collaborator Author

iAmmar7 commented Sep 5, 2023

Note: I need to add test cases once the APIs are ready from the server.

@iAmmar7 iAmmar7 changed the title WIP: Hand raise API for the video SDK Hand raise API for the video SDK Sep 11, 2023
@iAmmar7 iAmmar7 requested a review from edolix September 11, 2023 14:15
@iAmmar7
Copy link
Collaborator Author

iAmmar7 commented Nov 2, 2023

Test cases for both realtime-api and JS SDKs are ready for review.

giavac
giavac previously approved these changes Nov 6, 2023
@iAmmar7 iAmmar7 merged commit 6c9d2aa into main Nov 10, 2023
10 checks passed
@iAmmar7 iAmmar7 deleted the aa/hand-raise-api branch November 10, 2023 10:41
@iAmmar7 iAmmar7 mentioned this pull request Nov 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants