Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor problem when deleting mentions #128

Closed
wants to merge 1 commit into from

Conversation

wtr7
Copy link
Contributor

@wtr7 wtr7 commented Nov 22, 2016

Answer on issue #94. @jfschwarz

If I'm correct we should always set the cursor at the right position when the component did update. Currently there's a boolean called setSelectionAfterMentionChange that I believe is not needed. This boolean is initialised as false but when we open the examples we have standaard mention tags. When we then delete them, the cursor doesn't get to the right place because setSelectionAfterMentionChange is false. By not checking for setSelectionAfterMentionChange the cursor always gets to the right place of deleting.

We should always set the cursor at the right position when component did update
@jfschwarz
Copy link
Contributor

The setSelectionAfterMentionChange is used to prevent unnecessarily setting the selection, which might cause issues with complex inserts (e.g. see #40).

Receiving this PR, however, gave me the motivational push to further investigate the issue. :) I found a fix, which has been released with version 0.6.1

Thank you!

@jfschwarz jfschwarz closed this Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants