Fix cursor problem when deleting mentions #128
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answer on issue #94. @jfschwarz
If I'm correct we should always set the cursor at the right position when the component did update. Currently there's a boolean called setSelectionAfterMentionChange that I believe is not needed. This boolean is initialised as false but when we open the examples we have standaard mention tags. When we then delete them, the cursor doesn't get to the right place because setSelectionAfterMentionChange is false. By not checking for setSelectionAfterMentionChange the cursor always gets to the right place of deleting.