Replace deprecation warning #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pablo-ruth , I like these changes, warning message is clear for me 👍 |
|
Great thanks for your time discussing and resolving this issue :) I'll release this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #133
Hello @tierpod, following our discussion in #138. I kept the deprecation check but removed RSA from the list. I added a "buggy" check, that target RSA keys, as we know that in a certain combination of client/server version the authentication is failing. I conditioned the warning so it's displayed only for users that are using only rsa (or deprecated) keys, so that when you have at least one non-rsa key you are not disturbed by it.
I will be happy to have your opinion on it :)