-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to structured logging #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jmezo, for this PR! I have left some comments.
Additionally, it would be appreciated if you could update the logging statements to add spaces around =
, similar to the following:
Lines 656 to 661 in ec561f2
warn!( | |
source = %request_call.contact(), | |
message_nonce = hex::encode(request_call.packet().message_nonce()), | |
expected_nonce = hex::encode(request_nonce), | |
"Received a WHOAREYOU from a non expected source." | |
); |
Co-authored-by: Akihito Nakano <sora.akatsuki@gmail.com>
Thanks for the review and suggestions @ackintosh. I added the spaces around Let me know if the commits should be squashed, or if there are any other issues. |
FYI: The clippy errors will be fixed by #259 |
Co-authored-by: Akihito Nakano <sora.akatsuki@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Changes logging statements from using string formatting to structured logging. Closes #222
Change checklist
[ ] Documentation updates if relevant