Increase default vote duration to 2 minutes #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been looking into complications with low ipv6 peers in real world networks.
Originally this default was set, to handle ip changes more rapidly, however with low ipv6 peers on networks this becomes a hindering factor.
Although it is configurable, the default should be large enough to accommodate real-world networks.
I think this might have been originally set when we ping'd every connection. As no longer do that, maintaining pong votes for 2 minutes seems to be a reasonable tradeoff.