Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled Eth1Block test #1835

Closed
paulhauner opened this issue Oct 28, 2020 · 2 comments
Closed

Fix disabled Eth1Block test #1835

paulhauner opened this issue Oct 28, 2020 · 2 comments

Comments

@paulhauner
Copy link
Member

Description

As per #1765 (comment), we need to resolve this:

// FIXME(sproul): move Eth1Block to consensus/types
// ssz_static_test!(eth1_block, Eth1Block);

Notes

@michaelsproul
Copy link
Member

I'm removing this FIXME in #2279 because I don't think that test is relevant to us. The Eth1Block from the spec is a loosely defined object, and our Eth1Block has two more fields than it:

/// A block of the eth1 chain.
#[derive(Debug, PartialEq, Clone, Serialize, Deserialize, Encode, Decode)]
pub struct Eth1Block {
pub hash: Hash256,
pub timestamp: u64,
pub number: u64,
pub deposit_root: Option<Hash256>,
pub deposit_count: Option<u64>,
}

@michaelsproul
Copy link
Member

Same reasoning applies to new merge type PowBlock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants