Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Altair consensus changes and refactors #2279

Closed
wants to merge 107 commits into from

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Implement the consensus changes necessary for the upcoming Altair hard fork.

Additional Info

This is quite a heavy refactor, with pivotal types like the BeaconState and BeaconBlock changing from structs to enums. This ripples through the whole codebase with field accesses changing to methods, e.g. state.slot => state.slot().

@michaelsproul michaelsproul added the work-in-progress PR is a work-in-progress label Mar 23, 2021
@michaelsproul

This comment has been minimized.

@michaelsproul

This comment has been minimized.

@michaelsproul

This comment has been minimized.

SignedBeaconBlock failing due to INT_MAX slot issue
TreeHashing for BeaconState failing
Cached tree hashing for BeaconState currently disabled
@michaelsproul

This comment has been minimized.

@michaelsproul
Copy link
Member Author

Will fix merge conflicts here shortly before merging (in order to reduce churn in all the downstream PRs)

Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it!

@michaelsproul
Copy link
Member Author

Can't quite believe it... let's try this

bors r+

🎉

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 9, 2021
bors bot pushed a commit that referenced this pull request Jul 9, 2021
## Proposed Changes

Implement the consensus changes necessary for the upcoming Altair hard fork.

## Additional Info

This is quite a heavy refactor, with pivotal types like the `BeaconState` and `BeaconBlock` changing from structs to enums. This ripples through the whole codebase with field accesses changing to methods, e.g. `state.slot` => `state.slot()`.


Co-authored-by: realbigsean <seananderson33@gmail.com>
@bors bors bot changed the title Altair consensus changes and refactors [Merged by Bors] - Altair consensus changes and refactors Jul 9, 2021
@bors bors bot closed this Jul 9, 2021
@michaelsproul michaelsproul deleted the altair branch July 28, 2021 01:49
bors bot pushed a commit that referenced this pull request Aug 4, 2021
## Issue Addressed

Resolves #2278 

## Proposed Changes

Implements the networking components for the Altair hard fork https://github.com/ethereum/eth2.0-specs/blob/dev/specs/altair/p2p-interface.md

## Additional Info

This PR acts as the base branch for networking changes and tracks #2279 . Changes to gossip, rpc and discovery can be separate PRs to be merged here for ease of review.

Co-authored-by: realbigsean <seananderson33@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v1.5.0 For inclusion in v1.5.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants