-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Altair consensus changes and refactors #2279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SignedBeaconBlock failing due to INT_MAX slot issue TreeHashing for BeaconState failing Cached tree hashing for BeaconState currently disabled
This comment has been minimized.
This comment has been minimized.
…/lighthouse into altair-process-epoch � Conflicts: � consensus/state_processing/src/per_epoch_processing/base.rs
michaelsproul
commented
Mar 26, 2021
Will fix merge conflicts here shortly before merging (in order to reduce churn in all the downstream PRs) |
[Altair] Update to latest spec v1.1.0-alpha.6
Update to spec v1.1.0-alpha.7
This was referenced Jul 7, 2021
paulhauner
approved these changes
Jul 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge it!
Can't quite believe it... let's try this bors r+ 🎉 |
michaelsproul
added
ready-for-merge
This PR is ready to merge.
and removed
ready-for-review
The code is ready for review
labels
Jul 9, 2021
bors bot
pushed a commit
that referenced
this pull request
Jul 9, 2021
## Proposed Changes Implement the consensus changes necessary for the upcoming Altair hard fork. ## Additional Info This is quite a heavy refactor, with pivotal types like the `BeaconState` and `BeaconBlock` changing from structs to enums. This ripples through the whole codebase with field accesses changing to methods, e.g. `state.slot` => `state.slot()`. Co-authored-by: realbigsean <seananderson33@gmail.com>
Pull request successfully merged into unstable. Build succeeded: |
bors
bot
changed the title
Altair consensus changes and refactors
[Merged by Bors] - Altair consensus changes and refactors
Jul 9, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
## Issue Addressed Resolves #2278 ## Proposed Changes Implements the networking components for the Altair hard fork https://github.com/ethereum/eth2.0-specs/blob/dev/specs/altair/p2p-interface.md ## Additional Info This PR acts as the base branch for networking changes and tracks #2279 . Changes to gossip, rpc and discovery can be separate PRs to be merged here for ease of review. Co-authored-by: realbigsean <seananderson33@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implement the consensus changes necessary for the upcoming Altair hard fork.
Additional Info
This is quite a heavy refactor, with pivotal types like the
BeaconState
andBeaconBlock
changing from structs to enums. This ripples through the whole codebase with field accesses changing to methods, e.g.state.slot
=>state.slot()
.