Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse v4.3.0 doesn't send Eth-Consensus-Version header #4525

Closed
xenowits opened this issue Jul 21, 2023 · 3 comments
Closed

Lighthouse v4.3.0 doesn't send Eth-Consensus-Version header #4525

xenowits opened this issue Jul 21, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers HTTP-API v4.4.1 ETA August 2023

Comments

@xenowits
Copy link

Description

The /eth/v1/validator/blinded_blocks endpoint doesn't send the Eth-Consensus-Version header in the latest lighthouse release v4.3.0.

This breaks compatibility with clients that consume this API which errors when it can't find the Eth-Consensus-Version header in the response.

Version

Lighthouse/v4.3.0-dfcb336/x86_64-linux

Present Behaviour

Lighthouse BN doesn't return the Eth-Consensus-Version header in the response to API call to /eth/v1/validator/blinded_blocks endpoint.

See this screenshot:
Screenshot 2023-07-20 at 20 58 44

curl --location 'http://lighthouse-bn-v4.3.0/eth/v1/validator/blinded_blocks/{slot}?randao_reveal=0xc00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000&skip_randao_verification='

Expected Behaviour

Lighthouse BN should return the Eth-Consensus-Version header in the response to API call to /eth/v1/validator/blinded_blocks endpoint.

Steps to resolve

None.
@jimmygchen jimmygchen added the bug Something isn't working label Jul 21, 2023
@jimmygchen
Copy link
Member

Thanks for raising this bug! It looks like we're also missing the Eth-Consensus-Version header in the GET /eth/v1/validator/blocks endpoint as well.

@jimmygchen jimmygchen added HTTP-API good first issue Good for newcomers v4.4.1 ETA August 2023 labels Jul 21, 2023
@Gua00va
Copy link
Contributor

Gua00va commented Jul 21, 2023

I would like to work on this issue.

@Gua00va Gua00va mentioned this issue Jul 21, 2023
Closed
@dB2510 dB2510 mentioned this issue Jul 26, 2023
Merged
obol-bulldozer bot pushed a commit to ObolNetwork/charon that referenced this issue Jul 26, 2023
@dB2510
gomod: downgrade go-eth2-client to v0.17.0 (#2474)
dab31bd 
Downgrades `go-eth2-client` to v0.17.0 to remain compatible with lighthouse because of this issue: sigp/lighthouse#4525

category: misc
ticket: none
@Gua00va Gua00va mentioned this issue Jul 26, 2023
Closed
bors bot pushed a commit that referenced this issue Jul 31, 2023
@Gua00va
Add Eth Version Header (#4528)
117802c 
## Issue Addressed
Closes #4525 

## Proposed Changes
`GET /eth/v1/validator/blinded_blocks` endpoint and `GET /eth/v1/validator/blocks`  now send `Eth-Version` header.

Co-authored-by: Gua00va <105484243+Gua00va@users.noreply.github.com>
@jimmygchen
Copy link
Member

Completed in #4528 🎉

Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@Gua00va @Woodpile37
Add Eth Version Header (sigp#4528)
5dd60c5 
## Issue Addressed
Closes sigp#4525 

## Proposed Changes
`GET /eth/v1/validator/blinded_blocks` endpoint and `GET /eth/v1/validator/blocks`  now send `Eth-Version` header.

Co-authored-by: Gua00va <105484243+Gua00va@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers HTTP-API v4.4.1 ETA August 2023
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jimmygchen @xenowits @Gua00va