Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 404 instead of 405 in VC HTTP API #4596

Closed
michaelsproul opened this issue Aug 10, 2023 · 9 comments
Closed

Return 404 instead of 405 in VC HTTP API #4596

michaelsproul opened this issue Aug 10, 2023 · 9 comments
Labels
good first issue Good for newcomers HTTP-API low-hanging-fruit Easy to resolve, get it before someone else does! val-client Relates to the validator client binary

Comments

@michaelsproul
Copy link
Member

Description

We fixed #3112 in the beacon node API but the same issue affects the validator client API. See that issue and the BN fix for details: #3836

An example of a request that triggers the error:

curl -s -H "Authorization: Bearer "(cat token.txt) "http://localhost:5062/not_found" | jq
{
  "code": 405,
  "message": "METHOD_NOT_ALLOWED",
  "stacktraces": []
}
@michaelsproul michaelsproul added good first issue Good for newcomers val-client Relates to the validator client binary low-hanging-fruit Easy to resolve, get it before someone else does! HTTP-API labels Aug 10, 2023
@ameya-deshmukh
Copy link

Taking this up!

@Gua00va
Copy link
Contributor

Gua00va commented Aug 26, 2023 •
edited
Loading

@michaelsproul , I would like to take up this one!

@michaelsproul
Copy link
Member Author

@ameya-deshmukh Did you end up implementing this already?

@ameya-deshmukh
Copy link

Yes! Opening a PR today/tomorrow.

@aoikurokawa
Copy link
Contributor

@ameya-deshmukh are you still working on this ? If not i would love to take it on

@ameya-deshmukh
Copy link

Hey @aoikurokawa I am! Will let you know if I don't find the time, but I am expecting it to be done soon. Sorry for the delay @michaelsproul, hope it's fine.

@duguorong009 duguorong009 mentioned this issue Sep 20, 2023
Closed
@duguorong009
Copy link
Contributor

duguorong009 commented Sep 20, 2023 •
edited
Loading

Hey, @ameya-deshmukh
I am really sorry to open PR without any notice.
But, you haven't replied to my Discord friend request.
And I found this issue is not that hard, and have good starting points.
So, I ended up creating PR in some hours.

@michaelsproul
Can you review the PR #4758 & give the comments?
Thx in advance!

@ameya-deshmukh
Copy link

Hey no worries! Didn't get the time to work on this unfortunately :(
Thanks for taking it up :)

bors bot pushed a commit that referenced this issue Sep 29, 2023
@duguorong009
fix(validator_client): return http 404 rather than 405 in http api (#…
3e855f7 
…4758)

## Issue Addressed
- Close #4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR #3836
bors bot pushed a commit that referenced this issue Sep 29, 2023
@duguorong009
fix(validator_client): return http 404 rather than 405 in http api (#…
20a5ff7 
…4758)

## Issue Addressed
- Close #4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR #3836
bors bot pushed a commit that referenced this issue Sep 29, 2023
@duguorong009
fix(validator_client): return http 404 rather than 405 in http api (#…
69ba3ef 
…4758)

## Issue Addressed
- Close #4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR #3836
bors bot pushed a commit that referenced this issue Oct 4, 2023
@duguorong009
fix(validator_client): return http 404 rather than 405 in http api (#…
7d53721 
…4758)

## Issue Addressed
- Close #4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR #3836
@chong-he
Copy link
Member

Closing this as this is solved in #4758

Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@duguorong009 @Woodpile37
fix(validator_client): return http 404 rather than 405 in http api (s…
4cf2998 
…igp#4758)

## Issue Addressed
- Close sigp#4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR sigp#3836
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@duguorong009 @Woodpile37
fix(validator_client): return http 404 rather than 405 in http api (s…
68eece8 
…igp#4758)

## Issue Addressed
- Close sigp#4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR sigp#3836
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@duguorong009 @Woodpile37
fix(validator_client): return http 404 rather than 405 in http api (s…
a0372fe 
…igp#4758)

## Issue Addressed
- Close sigp#4596 

## Proposed Changes
- Add `Filter::recover` to handle rejections specifically as 404 NOT FOUND

Please list or describe the changes introduced by this PR.

## Additional Info

Similar to PR sigp#3836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers HTTP-API low-hanging-fruit Easy to resolve, get it before someone else does! val-client Relates to the validator client binary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@michaelsproul @chong-he @aoikurokawa @ameya-deshmukh @duguorong009 @Gua00va