You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #4900 we no longer have the block root in a blob sidecar. We sometimes need the block root when we only have a sidecar, especially in RPC when calculating BlobIdentifier.
We should try to figure out how important caching this actually is, and if it's worth the effort of making sure we don't re-calculate the block root for a blob sidecar. Or since we're calculating it per-sidecar, (and again in the actual block), maybe we could cache it across sidecars and check equivalence.
But the SignedBlockHeader is very small, so I'm not sure it'll have a big impact
The text was updated successfully, but these errors were encountered:
With #4900 we no longer have the block root in a blob sidecar. We sometimes need the block root when we only have a sidecar, especially in RPC when calculating BlobIdentifier.
We should try to figure out how important caching this actually is, and if it's worth the effort of making sure we don't re-calculate the block root for a blob sidecar. Or since we're calculating it per-sidecar, (and again in the actual block), maybe we could cache it across sidecars and check equivalence.
But the SignedBlockHeader is very small, so I'm not sure it'll have a big impact
The text was updated successfully, but these errors were encountered: