Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block root caching in blob sidecar #4948

Closed
realbigsean opened this issue Nov 24, 2023 · 1 comment
Closed

Block root caching in blob sidecar #4948

realbigsean opened this issue Nov 24, 2023 · 1 comment
Labels

Comments

@realbigsean
Copy link
Member

With #4900 we no longer have the block root in a blob sidecar. We sometimes need the block root when we only have a sidecar, especially in RPC when calculating BlobIdentifier.

We should try to figure out how important caching this actually is, and if it's worth the effort of making sure we don't re-calculate the block root for a blob sidecar. Or since we're calculating it per-sidecar, (and again in the actual block), maybe we could cache it across sidecars and check equivalence.

But the SignedBlockHeader is very small, so I'm not sure it'll have a big impact

@realbigsean
Copy link
Member Author

@pawanjay176 checked this out and it looks like calculating the block root from a header takes microseconds so this does not seem worth optimizing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant