Sidecar inclusion self review cleanup #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realbigsean
commented
Nov 24, 2023
| @@ -888,7 +887,6 @@ pub struct SseBlock { | |||
| } | |||
|
|
|||
| #[derive(PartialEq, Debug, Serialize, Deserialize, Clone)] | |||
| // TODO(pawan): modify spec to maybe include proofs too? | |||
There was a problem hiding this comment.
Since we don't send the full block in the block event, I think it's ok to omit the inclusion proofs
There was a problem hiding this comment.
Ohh did not realise this, seems good then
pawanjay176
approved these changes
Nov 24, 2023
| @@ -888,7 +887,6 @@ pub struct SseBlock { | |||
| } | |||
|
|
|||
| #[derive(PartialEq, Debug, Serialize, Deserialize, Clone)] | |||
| // TODO(pawan): modify spec to maybe include proofs too? | |||
There was a problem hiding this comment.
Ohh did not realise this, seems good then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ef_testsfeature to mock out theproposing_at_re_org_slotlogicGossipVerifiedBlobto make sure we calculate it at least once less, but we do calculate it other times, opened an issue related to this here: Block root caching in blob sidecar #4948