Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up naming of VariableList/FixedVector on tree-states #5141

Closed
michaelsproul opened this issue Jan 30, 2024 · 1 comment
Closed

Clean up naming of VariableList/FixedVector on tree-states #5141

michaelsproul opened this issue Jan 30, 2024 · 1 comment
Assignees
Labels
code-quality tree-states Upcoming state and database overhaul

Comments

@michaelsproul
Copy link
Member

Description

At the moment tree-states has a confusing mix of type aliases for the VariableList/FixedVector types. To remedy the situation I'm proposing to instead use these names:

  • VariableList/FixedVector: same as on stable, refer to types from ssz_types
  • List/Vector: unmodified milhouse type names

Alternatively, we could alias both libraries with new names:

  • TreeList/TreeVector: type aliases for milhouse types
  • FlatList/FlatVector: type aliases for ssz_types types

However I think avoiding aliases altogether is probably clearer.

@michaelsproul michaelsproul added code-quality tree-states Upcoming state and database overhaul labels Jan 30, 2024
@dapplion
Copy link
Collaborator

  • VariableList/FixedVector: same as on stable, refer to types from ssz_types
  • List/Vector: unmodified milhouse type names

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality tree-states Upcoming state and database overhaul
Projects
None yet
Development

No branches or pull requests

2 participants