Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure safe usage of RwLocks are safe in beacon_node_fallback #6459

Open
jimmygchen opened this issue Oct 3, 2024 · 1 comment
Open

Ensure safe usage of RwLocks are safe in beacon_node_fallback #6459

jimmygchen opened this issue Oct 3, 2024 · 1 comment
Labels
v6.0.0 New major release for hierarchical state diffs

Comments

@jimmygchen
Copy link
Member

Description

#4393 introduces some new usage of RwLock in beacon_node_fallback. This ensures safe, concurrent access to node health data across threads. We've done a round of review on this and don't think there's any deadlock risk, or any locks being held for too long, however there are areas we could potentially simplify and improve on:

@jimmygchen jimmygchen added the v6.0.0 New major release for hierarchical state diffs label Oct 3, 2024
@eserilev
Copy link
Collaborator

eserilev commented Oct 7, 2024

fwiw lockbud isn't picking up any deadlocks in beacon_node_fallback. You can see the results in the lockbud CI step in this PR #6470

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v6.0.0 New major release for hierarchical state diffs
Projects
None yet
Development

No branches or pull requests

3 participants
@jimmygchen @eserilev and others