Add lockbud task to CI

[eserilev]

Issue Addressed

Closes #6413

Proposed Changes

Add lockbud to CI

Additional Info

Lockbud was pinned to 2024-05-20 Rust nightly. This conflicted with lazy_lock as it used to be an unstable feature. I've opened a PR here to pin it to the current latest Rust nightly (2024-10-05). I'm not sure if my changes have introduced any regressions, hopefully the author will review it soon and give some feedback.

BurtonQin/lockbud#70

Currently the new CI step uses a docker image hosted on my account

Steps to generate the docker image:

• Checkout https://github.com/eserilev/lockbud docker-instance branch
• Run docker build --platform linux/amd64 -t [namespace]/[repository] -f Dockerfile .
• Push the resulting image to docker hub

[eserilev]

We're getting a hit on a potential double lock here

[
      {
        "DoubleLock": {
          "bug_kind": "DoubleLock",
          "possibility": "Possibly",
          "diagnosis": {
            "first_lock_type": "ParkingLotRead(inner::DepositUpdater)",
            "first_lock_span": "beacon_node/eth1/src/service.rs:552:9: 553:20 (#0)",
            "second_lock_type": "ParkingLotRead(inner::DepositUpdater)",
            "second_lock_span": "beacon_node/eth1/src/service.rs:535:29: 535:51 (#0)",
            "callchains": [
              [
                [
                  "beacon_node/eth1/src/service.rs:555:40: 555:65 (#0)"
                ]
              ]
            ]
          },
          "explanation": "The first lock is not released when acquiring the second lock"
        }
      }
    ]

It seems to be a false positive as these are read locks

[jimmygchen]

beacon_node/eth1/src/service.rs:555

Oh nice catch! i think this could potentially deadlock because we try to acquire a 2nd lock on self.deposits in the same thread, so if another thread tries to acquire a write lock in between, then we get a deadlock.

[dapplion]

Great to have lockbud on CI :)

[michaelsproul]

@mergify queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 352a9cf