Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add toledo support #1874

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Add toledo support #1874

wants to merge 5 commits into from

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Nov 9, 2020

Issue Addressed

NA

Proposed Changes

Adds support for the Toledo dev-net.

lighthouse --testnet toledo bn --http

This is for development only, we do not recommend users to join this testnet.

Additional Info

@paulhauner paulhauner added ready-for-review The code is ready for review blocked A1 and removed ready-for-review The code is ready for review labels Nov 9, 2020
Copy link
Member

@pawanjay176 pawanjay176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally. Works fine, finding peers and waiting for genesis 👍
LGTM! Just a minor typo in the config comment.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I found a bunch of peers instantly, so I'm happy with that

@paulhauner
Copy link
Member Author

Thanks @michaelsproul and @pawanjay176!

bors r+

@bors
Copy link

bors bot commented Nov 10, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Nov 10, 2020
@michaelsproul
Copy link
Member

bors retry

@bors
Copy link

bors bot commented Nov 10, 2020

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@paulhauner
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2020
## Issue Addressed

NA

## Proposed Changes

Adds support for the [Toledo](https://github.com/protolambda/toledo) dev-net.

```bash
lighthouse --testnet toledo bn --http
```

This is for development only, we do not recommend users to join this testnet.

## Additional Info

- ~~Blocked on #1862~~
@bors bors bot changed the title Add toledo support [Merged by Bors] - Add toledo support Nov 10, 2020
@bors bors bot closed this Nov 10, 2020
blacktemplar added a commit to blacktemplar/lighthouse that referenced this pull request Nov 17, 2020
## Issue Addressed

NA

## Proposed Changes

Adds support for the [Toledo](https://github.com/protolambda/toledo) dev-net.

```bash
lighthouse --testnet toledo bn --http
```

This is for development only, we do not recommend users to join this testnet.

## Additional Info

- ~~Blocked on sigp#1862~~

(cherry picked from commit 9ee71d6)
@paulhauner paulhauner deleted the toledo branch January 20, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants