Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use windows-2019 in release CI #3090

Closed
wants to merge 2 commits into from

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Address a CI failure in the release suite.

Example: https://github.com/sigp/lighthouse/actions/runs/1984266187

Additional Info

I believe we should merge this into unstable and stable. Then, move the v2.1.4 commit to target the commit with the updated CI. It's sad that v2.1.4 has two commits, but they're functionally equivalent for users.

@paulhauner paulhauner added ready-for-review The code is ready for review v2.1.4 labels Mar 15, 2022
@paulhauner paulhauner changed the base branch from stable to unstable March 15, 2022 03:07
@paulhauner
Copy link
Member Author

paulhauner commented Mar 15, 2022

FYI #3040 switched all of the test suite actions over to windows-2019 but I forgot about the release suite.

@AgeManning
Copy link
Member

bors r+

@bors
Copy link

bors bot commented Mar 15, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

bors bot pushed a commit that referenced this pull request Mar 15, 2022
## Issue Addressed

NA

## Proposed Changes

Address a CI failure in the release suite.

Example: https://github.com/sigp/lighthouse/actions/runs/1984266187

## Additional Info

I believe we should merge this into `unstable` and `stable`. Then, move the `v2.1.4` commit to target the commit with the updated CI. It's sad that v2.1.4 has two commits, but they're functionally equivalent for users.
@bors bors bot changed the title Use windows-2019 in release CI [Merged by Bors] - Use windows-2019 in release CI Mar 15, 2022
@bors bors bot closed this Mar 15, 2022
paulhauner added a commit to paulhauner/lighthouse that referenced this pull request May 6, 2022
## Issue Addressed

NA

## Proposed Changes

Address a CI failure in the release suite.

Example: https://github.com/sigp/lighthouse/actions/runs/1984266187

## Additional Info

I believe we should merge this into `unstable` and `stable`. Then, move the `v2.1.4` commit to target the commit with the updated CI. It's sad that v2.1.4 has two commits, but they're functionally equivalent for users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review v2.1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants