-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add Ropsten configuration #3184
Conversation
|
Looks like the config was updated here eth-clients/merge-testnets@5b1b44a |
That commit modifies shadow-fork-5, without touching ropsten. Thanks for point it out though! This PR is up-to-date with eth-clients/merge-testnets@5cbccd4 |
TTD is still subject to change, perhaps we should hold off merging until then? Or should we merge so we can roll out infra, and then ship an update as necessary? |
I think this is my preference, but not a strong one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Exciting to have a new network supported!
bors r+ |
## Issue Addressed NA ## Proposed Changes Adds the configuration for the upcoming merge of the Ropsten network, as per: eth-clients/merge-testnets#9 Use the Ropsten network with: `lighthouse --network ropsten` ## Additional Info This is still a work-in-progress. We should wait for the eth-clients/merge-testnets PR to be approved before merging this into our `unstable`.
Issue Addressed
NA
Proposed Changes
Adds the configuration for the upcoming merge of the Ropsten network, as per:
eth-clients/merge-testnets#9
Use the Ropsten network with:
lighthouse --network ropsten
Additional Info
This is still a work-in-progress. We should wait for the eth-clients/merge-testnets PR to be approved before merging this into our
unstable
.