[Merged by Bors] - Register validator api #3194

realbigsean · 2022-05-19T21:25:27Z

Issue Addressed

Lays the groundwork for builder API changes by implementing the beacon-API's new register_validator endpoint

Proposed Changes

Add a routine in the VC that runs on startup (re-try until success), once per epoch or whenever suggested_fee_recipient is updated, signing ValidatorRegistrationData and sending it to the BN.
- TODO: gas_limit config options Clarify Gas Limit in Register Validator endpoint ethereum/builder-specs#17
BN only sends VC registration data to builders on demand, but VC registration data does update the BN's prepare proposer cache and send an updated fcU to a local EE. This is necessary for fee recipient consistency between the blinded and full block flow in the event of fallback. Having the BN only send registration data to builders on demand gives feedback directly to the VC about relay status. Also, since the BN has no ability to sign these messages anyways (so couldn't refresh them if it wanted), and validator registration is independent of the BN head, I think this approach makes sense.
Adds upcoming consensus spec changes for this PR Add new DomainType for application usage with "internal" namespace ethereum/consensus-specs#2884
- I initially applied the bit mask based on a configured application domain.. but I ended up just hard coding it here instead because that's how it's spec'd in the builder repo.
- Should application mask appear in the api?

…on endpoint to update cache for `ProposerPreparationData`

…d at appropriate times

…gister-validator-api � Conflicts: � validator_client/src/preparation_service.rs

beacon_node/http_api/tests/tests.rs

consensus/types/src/chain_spec.rs

validator_client/src/preparation_service.rs

realbigsean · 2022-05-24T17:02:57Z

validator_client/src/preparation_service.rs

+        let validator_registration_fut = async move {
+            loop {
+                if self.should_publish_at_current_slot(&spec) {
+                    //TODO(sean) we should probably make it so validator registrations happen well before the merge


Should probably sign on startup, but an epoch before merge seems reasonable to start submitting.. although I guess we don't want to flood the relays at once..

Since we should only publish unchanged signatures once per epoch, I think it's ok to remove this check. And I don't think people will use the builder flow until closer to the merge anyways. I think this is better than potentially flooding the relay an epoch before the merge

validator_client/src/preparation_service.rs

validator_client/src/signing_method/web3signer.rs

validator_client/src/preparation_service.rs

realbigsean · 2022-05-24T18:33:57Z

validator_client/src/preparation_service.rs

+                fee_recipient,
+                //TODO(sean) this is geth's default, we should make this configurable and maybe have the default be dynamic.
+                // Discussion here: https://github.com/ethereum/builder-specs/issues/17
+                gas_limit: 30_000_000,


I think making this configurable should be done in a follow up PR in order to unblock the larger mev-boost compatibility PR

…ns proposals flag

realbigsean · 2022-05-24T22:45:18Z

Ok this one's ready for review, it will conflict with #3213 but the conflicts should be pretty easy to resolve, happy to merge that one first and fix the conflicts here

paulhauner

Looking good! I just have a few minor nits.

It might be nice to make some issues for the TODOs before this merges. I'm happy to do that, here's a list so I don't forget (feel free to add):

Enable Web3Signer support.
Add support for custom gas values.
Use of timestamp value?

beacon_node/http_api/src/lib.rs

paulhauner · 2022-06-24T00:37:05Z

beacon_node/http_api/src/lib.rs

+                        "client" => client_addr
+                            .map(|a| a.to_string())
+                            .unwrap_or_else(|| "unknown".to_string()),


I'm interested in the motivation behind this. This would put validator IP info in our DEBG logs, which I don't think we usually do. I'm not against it if it's going to be useful.

This exists in the prepare_beacon_proposer, not sure the reasoning behind it being put there, but I can remove it from both if we'd like?

Oh interesting, I missed this on a review from an external contributor. Let's pull them both out if you don't mind.

beacon_node/http_api/src/lib.rs

paulhauner · 2022-06-24T04:28:21Z

validator_client/src/signing_method.rs

                };

                // Determine the Web3Signer message type.
                let message_type = object.message_type();

-                // The `fork_info` field is not required for deposits since they sign across the
-                // genesis fork version.
-                let fork_info = if let Web3SignerObject::Deposit { .. } = &object {


I'm wondering if we've lost this logic on purpose? I don't think we ever actually use Deposit, but it might be nice to have these here for future protections.

I split this method into two:

get_signature_from_root -- can be used for deposits and is used for validator registrations (validator registrations also sign across the genesis fork version)

get_signature -- used for everything else

So we can still sign over deposits with this method but will have to use get_signature_from_root. I added a check to this method to make sure no fork info is provided if those two types are being signed over.

validator_client/src/preparation_service.rs

paulhauner · 2022-06-24T05:35:23Z

consensus/types/src/application_domain.rs

+        match self {
+            // This value is an application index of 0 with the bitmask applied (so it's equivalent to the bit mask).
+            // Little endian hex: 0x00000001, Binary: 1000000000000000000000000
+            ApplicationDomain::Builder => 16777216,


It might be nice to have 16777216 as a constant so we don't repeat it in other places of the code. Might even be able to make this function a const fn?

Went with a constant here for now

consensus/types/src/chain_spec.rs

Co-authored-by: Paul Hauner <paul@paulhauner.com>

…an/lighthouse into register-validator-api

realbigsean · 2022-06-29T21:20:34Z

Use of timestamp value?

Made issues for the other two, but not sure I understand this one

paulhauner

Awesome, feel free to bors after we pull out those IP addresses 🚀

realbigsean · 2022-06-30T00:48:45Z

Already pulled them out in this commit: a73bafe

realbigsean · 2022-06-30T00:49:05Z

bors r+

## Issue Addressed Lays the groundwork for builder API changes by implementing the beacon-API's new `register_validator` endpoint ## Proposed Changes - Add a routine in the VC that runs on startup (re-try until success), once per epoch or whenever `suggested_fee_recipient` is updated, signing `ValidatorRegistrationData` and sending it to the BN. - TODO: `gas_limit` config options ethereum/builder-specs#17 - BN only sends VC registration data to builders on demand, but VC registration data *does update* the BN's prepare proposer cache and send an updated fcU to a local EE. This is necessary for fee recipient consistency between the blinded and full block flow in the event of fallback. Having the BN only send registration data to builders on demand gives feedback directly to the VC about relay status. Also, since the BN has no ability to sign these messages anyways (so couldn't refresh them if it wanted), and validator registration is independent of the BN head, I think this approach makes sense. - Adds upcoming consensus spec changes for this PR ethereum/consensus-specs#2884 - I initially applied the bit mask based on a configured application domain.. but I ended up just hard coding it here instead because that's how it's spec'd in the builder repo. - Should application mask appear in the api? Co-authored-by: realbigsean <sean@sigmaprime.io>

bors · 2022-06-30T02:47:08Z

Pull request successfully merged into unstable.

Build succeeded:

## Issue Addressed This PR is a subset of the changes in #3134. Unstable will still not function correctly with the new builder spec once this is merged, #3134 should be used on testnets ## Proposed Changes - Removes redundancy in "builders" (servers implementing the builder spec) - Renames `payload-builder` flag to `builder` - Moves from old builder RPC API to new HTTP API, but does not implement the validator registration API (implemented in #3194) Co-authored-by: sean <seananderson33@gmail.com> Co-authored-by: realbigsean <sean@sigmaprime.io>

realbigsean added 6 commits May 13, 2022 15:07

add validator registration endpoint and validator registration service

312bab3

Add validator registration service and signing domain

49fea56

Remove val registration service and cache from BN, use val registrati…

9b8cdda

…on endpoint to update cache for `ProposerPreparationData`

update signing

c591e7a

update proposer prep service to cache sent registrations and sign/sen…

2ab3f0a

…d at appropriate times

remove bitmask logic, hard code instead

10a03b5

realbigsean added work-in-progress PR is a work-in-progress bellatrix Required to support the Bellatrix Upgrade labels May 19, 2022

realbigsean added 4 commits May 20, 2022 09:21

Merge branch 'unstable' of https://github.com/sigp/lighthouse into re…

00c8957

…gister-validator-api � Conflicts: � validator_client/src/preparation_service.rs

add test

bddf03a

fix signing

e3a7033

allow mock el dead code

62a6cd8

realbigsean commented May 24, 2022

View reviewed changes

realbigsean added 5 commits May 24, 2022 14:22

Update beacon_node/http_api/tests/tests.rs

291895d

Update consensus/types/src/chain_spec.rs

885819b

Update validator_client/src/preparation_service.rs

edc8dce

Update validator_client/src/preparation_service.rs

b20d7fb

Update validator_client/src/preparation_service.rs

ca567fd

realbigsean commented May 24, 2022

View reviewed changes

validator_client/src/preparation_service.rs Show resolved Hide resolved

realbigsean commented May 24, 2022

View reviewed changes

realbigsean added 5 commits May 24, 2022 17:37

actually do bitmask operation in test

b3ee9b8

don't double publish changed keys on epoch boundary

bdbe795

only start the registration service if we have the private transactio…

3f66349

…ns proposals flag

publish registrations regardless of how close we are to the merge

ae061f0

fix lints, commented out tests for future web3signer addition

b759e8d

realbigsean added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels May 24, 2022

supress lint

054aa0f

paulhauner requested changes Jun 24, 2022

View reviewed changes

paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jun 24, 2022

realbigsean mentioned this pull request Jun 29, 2022

[Merged by Bors] - Remove builder redundancy #3294

Closed

realbigsean and others added 4 commits June 29, 2022 14:25

Update beacon_node/http_api/src/lib.rs

faa87d3

Co-authored-by: Paul Hauner <paul@paulhauner.com>

Update beacon_node/http_api/src/lib.rs

365e784

Co-authored-by: Paul Hauner <paul@paulhauner.com>

PR feedback

a73bafe

Merge branch 'register-validator-api' of https://github.com/realbigse…

76e23fc

…an/lighthouse into register-validator-api

realbigsean added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Jun 29, 2022

realbigsean mentioned this pull request Jun 29, 2022

[builder API] Enable Web3Signer tests for validator registration #3296

Closed

paulhauner approved these changes Jun 30, 2022

View reviewed changes

paulhauner added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jun 30, 2022

bors bot changed the title ~~Register validator api~~ [Merged by Bors] - Register validator api Jun 30, 2022

bors bot closed this Jun 30, 2022

come-maiz mentioned this pull request Sep 8, 2022

Support mev-boost in lighthouse flashbots/mev-boost#160

Closed

realbigsean deleted the register-validator-api branch November 21, 2023 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Merged by Bors] - Register validator api #3194

[Merged by Bors] - Register validator api #3194

realbigsean commented May 19, 2022

realbigsean May 24, 2022

realbigsean May 24, 2022

realbigsean May 24, 2022

realbigsean commented May 24, 2022

paulhauner left a comment

paulhauner Jun 24, 2022

realbigsean Jun 29, 2022

paulhauner Jun 29, 2022

paulhauner Jun 24, 2022

realbigsean Jun 29, 2022

paulhauner Jun 24, 2022

realbigsean Jun 29, 2022

realbigsean commented Jun 29, 2022 •

edited

Loading

paulhauner left a comment

realbigsean commented Jun 30, 2022

realbigsean commented Jun 30, 2022

bors bot commented Jun 30, 2022

[Merged by Bors] - Register validator api #3194

[Merged by Bors] - Register validator api #3194

Conversation

realbigsean commented May 19, 2022

Issue Addressed

Proposed Changes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

realbigsean commented May 24, 2022

paulhauner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

realbigsean commented Jun 29, 2022 • edited Loading

paulhauner left a comment

Choose a reason for hiding this comment

realbigsean commented Jun 30, 2022

realbigsean commented Jun 30, 2022

bors bot commented Jun 30, 2022

realbigsean commented Jun 29, 2022 •

edited

Loading