Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add finalized to HTTP API responses #3753

Closed
wants to merge 28 commits into from
Closed

[Merged by Bors] - Add finalized to HTTP API responses #3753

wants to merge 28 commits into from

Commits on Nov 29, 2022

  1. Add finalized flag to /eth/v2/beacon/blocks/{block_id}

    @danielrachi1
    danielrachi1 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ee990af View commit details
    Browse the repository at this point in the history

  2. Add finalized flag to beacon/blocks/{block_id}/root

    @danielrachi1
    danielrachi1 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4f8a14e View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. fix is_finalized function

    @danielrachi1
    danielrachi1 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    d4fb8e1 View commit details
    Browse the repository at this point in the history

  2. replace is_finalized (BlockId) for is_finalized_block (BeaconChain)

    @danielrachi1
    danielrachi1 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    c827f29 View commit details
    Browse the repository at this point in the history

  3. delete is_finalized function

    @danielrachi1
    danielrachi1 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    5679214 View commit details
    Browse the repository at this point in the history

  4. Add finalized flag to beacon/blocks/{block_id}/attestations

    @danielrachi1
    danielrachi1 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    953ea6d View commit details
    Browse the repository at this point in the history

  5. Add finalized flag to beacon/blinded_blocks/{block_id}

    @danielrachi1
    danielrachi1 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    9c60a65 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. implement is_finalized_state in BeaconChain

    @danielrachi1
    danielrachi1 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c020bef View commit details
    Browse the repository at this point in the history

  2. Add finalized flag to beacon/states/{state_id}/*

    @danielrachi1
    danielrachi1 committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    948ce11 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2022

  1. Add finalized flag to GET beacon/headers and GET beacon/headers/{bloc… 

    …k_id}
    @danielrachi1
    danielrachi1 committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    baf1d16 View commit details
    Browse the repository at this point in the history

  2. Add finalized flag to GET debug/beacon/states/{state_id}

    @danielrachi1
    danielrachi1 committed Dec 4, 2022
    Configuration menu
    Copy the full SHA
    79fd163 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Remove execution_optimistic_fork_versioned_response

    @danielrachi1
    danielrachi1 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    5024517 View commit details
    Browse the repository at this point in the history

  2. Proper error handling for the finalized flag

    @danielrachi1
    danielrachi1 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    6e8be18 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Update BeaconNodeHttpClient to handle finalized responses

    @danielrachi1
    danielrachi1 committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    5802d05 View commit details
    Browse the repository at this point in the history

  2. Add tests for the finalized flag

    @danielrachi1
    danielrachi1 committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    d3eb156 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. fix tests

    @danielrachi1
    danielrachi1 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5e049e1 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. StateId::root() now returns info about finalization

    @danielrachi1
    danielrachi1 committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    3da1985 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. StateId::map_state_and_execution_optimistic passes the finalized status

    @danielrachi1
    danielrachi1 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    e483075 View commit details
    Browse the repository at this point in the history

  2. BlockId::root returns info about finalization

    @danielrachi1
    danielrachi1 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    1deb787 View commit details
    Browse the repository at this point in the history

  3. fix justified finalization response

    @danielrachi1
    danielrachi1 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    b49f80b View commit details
    Browse the repository at this point in the history

  4. update tests

    @danielrachi1
    danielrachi1 committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3f07b7e View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Replace .state call for .map_state_and_execution_optimistic

    @danielrachi1
    danielrachi1 committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    b0366ee View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Fix .map_state_and_execution_optimistic() function name

    @danielrachi1
    danielrachi1 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    11cd2ee View commit details
    Browse the repository at this point in the history

  2. Solve merge conflicts (Merge unstable into add_finalized_flag)

    @danielrachi1
    danielrachi1 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    787b00e View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch 'unstable' of github.com:sigp/lighthouse into add_finali… 

    …zed_flag
    @danielrachi1
    danielrachi1 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    566bb66 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Merge remote-tracking branch 'origin/unstable' into add_finalized_flag

    @michaelsproul
    michaelsproul committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1bc5b97 View commit details
    Browse the repository at this point in the history

  2. A few clean-ups and optimisations 

    - Remove unnecessary tuple nesting like `((data, finalized), optimistic)`
- Return `finalized` from `BlockId` functions to avoid repeated block loads from disk
- Add `finalized` status to new rewards APIs added after this PR was opened
    @michaelsproul
    michaelsproul committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    5e2be5f View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @michaelsproul
    michaelsproul committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    51465c5 View commit details
    Browse the repository at this point in the history