Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove the unused ExecutionOptimisticForkVersionedResponse type #4160

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove the unused ExecutionOptimisticForkVersionedResponse type #4160

wants to merge 1 commit into from

Conversation

macladson
Copy link
Member

Issue Addressed

#4146

Proposed Changes

Removes the ExecutionOptimisticForkVersionedResponse type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.

@macladson macladson added work-in-progress PR is a work-in-progress ready-for-review The code is ready for review code-quality and removed work-in-progress PR is a work-in-progress labels Apr 3, 2023
michaelsproul
michaelsproul approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Mac, deleter of worlds ⌨️

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v4.1.0 Post-Capella minor release and removed ready-for-review The code is ready for review labels Apr 12, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 12, 2023
@macladson
Remove the unused ExecutionOptimisticForkVersionedResponse type (#4160
0e2e23e 
)

## Issue Addressed

#4146 

## Proposed Changes

Removes the `ExecutionOptimisticForkVersionedResponse` type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.
@bors
Copy link

bors bot commented Apr 12, 2023

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Remove the unused ExecutionOptimisticForkVersionedResponse type [Merged by Bors] - Remove the unused ExecutionOptimisticForkVersionedResponse type Apr 12, 2023
@bors bors bot closed this Apr 12, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@macladson
Remove the unused ExecutionOptimisticForkVersionedResponse type (si…
50151b0 
…gp#4160)

## Issue Addressed

sigp#4146 

## Proposed Changes

Removes the `ExecutionOptimisticForkVersionedResponse` type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.
@michaelsproul michaelsproul mentioned this pull request Aug 17, 2023
Open
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@macladson @Woodpile37
Remove the unused ExecutionOptimisticForkVersionedResponse type (si…
7e4e606 
…gp#4160)

## Issue Addressed

sigp#4146 

## Proposed Changes

Removes the `ExecutionOptimisticForkVersionedResponse` type and the associated Beacon API endpoint which is now deprecated. Also removes the test associated with the endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
code-quality ready-for-merge This PR is ready to merge. v4.1.0 Post-Capella minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macladson @michaelsproul