-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge queue take two #4254
Merge queue take two #4254
Conversation
Co-authored-by: Paul Hauner <paul@paulhauner.com>
I think once the jobs are added to the admin UI this will be ready to merge. We can do that tomorrow (Weds). |
Just hotfixed the target branch check: it was failing because |
It seems like Github's merge queue works quite differently from Bors, in that it requires CI to finish on the branch before even adding it to the queue 😩 This is really annoying when CI takes 2 hours and we often push small corrections immediately before queueing. It means we essentially have to run CI twice on every PR with no option to skip. This is discussed in the public feedback as a "much wanted" feature:
Hopefully that gets implemented soon. In the meantime I think we should keep using Bors. |
Closing this for now as it's stale. We might be better off self-hosting Bors if they shutdown the main instance. |
Issue Addressed
Part of #4251
Proposed Changes
Add success jobs to
test-suite
andlocal-testnet
that list all other jobs as dependencies and use a script to check that they depend on all other jobs.