Harden against finalized block spam #4277
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
block_verification.rs
. This has the potential to halve the time spent rejecting these messages (from 10-20ms to 5-10ms).Ignore
d though rather than rejected, as that's what the spec requires.Reject
ed, which also aligns with the spec.Additional Info
check_block_against_anchor_slot
. I added it in 2021 when I implemented checkpoint sync, but it's superfluous because the anchor slot is always <= the finalized slot, so any block caught by the anchor check will be caught by the finalized slot check.BlockIsAlreadyKnown
,RepeatProposal
,NotFinalizedDescendant
,BlockIsNotLaterThanParent
,TooManySkippedSlots
are all prior to the proposer signature check.