[Merged by Bors] - Fix PERSIST_ETH1_CACHE / PERSIST_OP_POOL Metrics #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethDreamer
added
v1.4.0
paulhauner
approved these changes
May 16, 2023
There was a problem hiding this comment.
Nice one!
It will be a bit of a race condition to try and read the value before Lighthouse actually shuts down. IIRC we used to persist this cache a bit more regularly.
I guess we can just leave the metric here since it's not doing much harm and it's possible that we get some data from it 🤷
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 17, 2023
Do these metrics ever get read? As far as I'm aware, they're only ever updated when lighthouse is shutting down?
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
Do these metrics ever get read? As far as I'm aware, they're only ever updated when lighthouse is shutting down?
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Do these metrics ever get read? As far as I'm aware, they're only ever updated when lighthouse is shutting down?
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
Do these metrics ever get read? As far as I'm aware, they're only ever updated when lighthouse is shutting down?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do these metrics ever get read? As far as I'm aware, they're only ever updated when lighthouse is shutting down?