Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - CommitteeCache.get_all_beacon_committees: set correct capacity to avoid realloc #4557

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - CommitteeCache.get_all_beacon_committees: set correct capacity to avoid realloc #4557

wants to merge 1 commit into from

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Aug 1, 2023 •
edited by bors bot
Loading

No description provided.

@michaelsproul michaelsproul added optimization Something to make Lighthouse run more efficiently. consensus An issue/PR that touches consensus code, such as state_processing or block verification. labels Aug 2, 2023
@michaelsproul
Copy link
Member

Can you please re-target this PR at unstable? You'll need to rebase in order to re-trigger Github's CI

@zhiqiangxu zhiqiangxu force-pushed the opt_CommitteeCache.get_all_beacon_committees branch from 3bbf3b6 to 71bcd06 Compare August 2, 2023 01:23
@zhiqiangxu zhiqiangxu changed the base branch from stable to unstable August 2, 2023 01:24
@zhiqiangxu
Copy link
Contributor Author

Can you please re-target this PR at unstable? You'll need to rebase in order to re-trigger Github's CI

Done.

@michaelsproul michaelsproul added the ready-for-review The code is ready for review label Aug 2, 2023
@michaelsproul
Copy link
Member

sorry, I think it needs one more force push (you've gotta push a new commit after changing the base branch, github is fussy).

@zhiqiangxu zhiqiangxu force-pushed the opt_CommitteeCache.get_all_beacon_committees branch from 71bcd06 to 21bc8a8 Compare August 2, 2023 01:37
@zhiqiangxu
Copy link
Contributor Author

sorry, I think it needs one more force push (you've gotta push a new commit after changing the base branch, github is fussy).

Done again:)

paulhauner
paulhauner approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, I like it! Thank you.

Out of interest, did you find this by reading the code or by runtime analysis (e.g., heaptrack)?

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 2, 2023
@zhiqiangxu
Copy link
Contributor Author

Nice one, I like it! Thank you.

Out of interest, did you find this by reading the code or by runtime analysis (e.g., heaptrack)?

The former :)

@paulhauner
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 2, 2023
@zhiqiangxu
CommitteeCache.get_all_beacon_committees: set correct capacity to avo…
deb2677 
…id realloc (#4557)
@bors
Copy link

bors bot commented Aug 2, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 2, 2023
@zhiqiangxu
CommitteeCache.get_all_beacon_committees: set correct capacity to avo…
7399a54 
…id realloc (#4557)
@bors
Copy link

bors bot commented Aug 3, 2023

Pull request successfully merged into unstable.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title CommitteeCache.get_all_beacon_committees: set correct capacity to avoid realloc [Merged by Bors] - CommitteeCache.get_all_beacon_committees: set correct capacity to avoid realloc Aug 3, 2023
@bors bors bot closed this Aug 3, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@zhiqiangxu @Woodpile37
CommitteeCache.get_all_beacon_committees: set correct capacity to avo…
32abe69 
…id realloc (sigp#4557)
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@zhiqiangxu @Woodpile37
CommitteeCache.get_all_beacon_committees: set correct capacity to avo…
9399ffa 
…id realloc (sigp#4557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
consensus An issue/PR that touches consensus code, such as state_processing or block verification. optimization Something to make Lighthouse run more efficiently. ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @michaelsproul @paulhauner