Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - add metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST for post_validator_duties_sync #4617

Closed
wants to merge 1 commit into from

Conversation

zhiqiangxu
Copy link
Contributor

It seems post_validator_duties_sync is the only api which doesn't have its own metric in duties_service, this PR adds metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST for completeness.

@chong-he chong-he added the ready-for-review The code is ready for review label Aug 15, 2023
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 16, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 17, 2023
…ties_sync` (#4617)

It seems `post_validator_duties_sync` is the only api which doesn't have its own metric in `duties_service`, this PR adds `metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST` for completeness.
@bors
Copy link

bors bot commented Aug 17, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Aug 17, 2023
…ties_sync` (#4617)

It seems `post_validator_duties_sync` is the only api which doesn't have its own metric in `duties_service`, this PR adds `metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST` for completeness.
@michaelsproul
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Aug 17, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@bors
Copy link

bors bot commented Aug 17, 2023

Canceled.

@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Aug 17, 2023
…ties_sync` (#4617)

It seems `post_validator_duties_sync` is the only api which doesn't have its own metric in `duties_service`, this PR adds `metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST` for completeness.
@bors
Copy link

bors bot commented Aug 17, 2023

@bors bors bot changed the title add metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST for post_validator_duties_sync [Merged by Bors] - add metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST for post_validator_duties_sync Aug 17, 2023
@bors bors bot closed this Aug 17, 2023
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
…ties_sync` (sigp#4617)

It seems `post_validator_duties_sync` is the only api which doesn't have its own metric in `duties_service`, this PR adds `metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST` for completeness.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
…ties_sync` (sigp#4617)

It seems `post_validator_duties_sync` is the only api which doesn't have its own metric in `duties_service`, this PR adds `metrics::VALIDATOR_DUTIES_SYNC_HTTP_POST` for completeness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants