Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to get rid of the yanked deps #4994

Merged
merged 10 commits into from
Dec 15, 2023

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Dec 8, 2023

Issue Addressed

#4989

Proposed Changes

The yanked ahash v0.7.6 and ahash v0.8.3 were used by older versions of hashbrown in our depdencies: 0.11.2, 0.12.3. 0.14.0.

The following changes have been made:

  • cargo update -p hashbrown@0.14.0
  • cargo update -p ahash@0.7.6
  • Updated hyper, lru, serde_yaml, axum dep versions
  • Also sneaked in an unrelated change to bump testcontainers to 0.15 as I noticed that there's a new release and we weren't using a release version.

@michaelsproul
Copy link
Member

Looks like we are waiting on seanmonstar/reqwest#2059

@jimmygchen jimmygchen added the dependencies Pull requests that update a dependency file label Dec 8, 2023
Cargo.toml Outdated Show resolved Hide resolved
@michaelsproul
Copy link
Member

There was a patched version of ahash 0.7 all along (see tkaitchuck/aHash#163 (comment)). I just pushed a commit to update to it and now the warnings are gone 😁

watch/src/server/mod.rs Outdated Show resolved Hide resolved
@jimmygchen jimmygchen marked this pull request as ready for review December 8, 2023 04:52
@jimmygchen jimmygchen added ready-for-review The code is ready for review v4.6.0 ETA Q1 2024 labels Dec 8, 2023
@jimmygchen
Copy link
Member Author

The watch tests seem to be taking forever, looks like those changes aren't good. Will investigate.

@jimmygchen jimmygchen added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Dec 8, 2023
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Dec 11, 2023
@jimmygchen
Copy link
Member Author

It turns out the test issue was related to the usage of TcpListener::from_std, and require setting the TcpListener to set_nonblocking. Docs from TcpListener::from_std:

    /// The caller is responsible for ensuring that the listener is in
    /// non-blocking mode. Otherwise all I/O operations on the listener
    /// will block the thread, which will cause unexpected behavior.
    /// Non-blocking mode can be set using [`set_nonblocking`].

Thanks to @michaelsproul for finding and fixing this! 🎉

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's merge.

@michaelsproul michaelsproul merged commit b0c374c into sigp:unstable Dec 15, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready-for-review The code is ready for review v4.6.0 ETA Q1 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants