Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint for solving CLI tests failure #5041

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

paulhauner
Copy link
Member

Issue Addressed

NA

Proposed Changes

Adds a little hint for solving the CLI failures on CI. I suggested running ./scripts/cli.sh rather than make cli because I assume it will be faster for devs (it takes advantage of cargo caches).

Additional Info

NA

@paulhauner paulhauner added the ready-for-review The code is ready for review label Jan 8, 2024
scripts/cli.sh Outdated Show resolved Hide resolved
Copy link
Member

@macladson macladson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@macladson macladson added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jan 8, 2024
@realbigsean realbigsean merged commit f62cfc6 into sigp:unstable Jan 8, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants