Test backfill #5109
Merged
Test backfill #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
reviewed
Jan 23, 2024
Co-authored-by: João Oliveira <hello@jxs.pt>
|
oh nice! Thanks! |
jxs
reviewed
Jan 24, 2024
Comment on lines
843
to
849
| let backfill_epoch_range = (self.spec.min_validator_withdrawability_delay | ||
| + self.spec.churn_limit_quotient) | ||
| .as_u64() | ||
| / 2; | ||
| #[cfg(test_backfill)] | ||
| let backfill_epoch_range = 3; | ||
|
|
There was a problem hiding this comment.
Suggested change
| let backfill_epoch_range = (self.spec.min_validator_withdrawability_delay | |
| + self.spec.churn_limit_quotient) | |
| .as_u64() | |
| / 2; | |
| #[cfg(test_backfill)] | |
| let backfill_epoch_range = 3; |
this is no longer required right?
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 7582da7 |
AgeManning
added
ready-for-merge
jxs
approved these changes
Jan 31, 2024
|
@Mergifyio requeue |
❌ This pull request head commit has not been previously disembarked from queue. |
This was referenced Jan 31, 2024
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Feb 14, 2024
* Test backfill * Revert cargo.toml * Update beacon_node/beacon_chain/src/builder.rs Co-authored-by: João Oliveira <hello@jxs.pt> * Remove redundant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a feature flag in able to shorten the backfill distance for developers to help debug and diagnose issues with backfill syncing.