Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external LLVM version in preparation for Rust 1.76. #5179

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Feb 4, 2024

Issue Addressed

From Rust 1.76 (release in 3 days), minimum external LLVM version will be bumped to v16.

Creating this PR in advance so we don't forget, as we use this in the windows release build.

EDIT: this isn't actually being used for sigp releases as we're running on self hosted runners, but good to keep the CI updated anyway.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 4, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Very pro-active!

@jimmygchen
Copy link
Member Author

Depends on #5180 for a green CI.

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 6, 2024
@jimmygchen
Copy link
Member Author

@mergify queue

Copy link

mergify bot commented Feb 6, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4b62a02

@michaelsproul
Copy link
Member

@Mergifyio requeue

Copy link

mergify bot commented Feb 6, 2024

requeue

☑️ This pull request is already queued

mergify bot added a commit that referenced this pull request Feb 6, 2024
@mergify mergify bot merged commit 4b62a02 into sigp:unstable Feb 6, 2024
28 of 29 checks passed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
* Update external LLVM version in preparation for Rust 1.76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants