Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove curve25519-dalek patch #5214

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Remove curve25519-dalek patch #5214

merged 1 commit into from
Feb 8, 2024

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Feb 7, 2024 •
edited
Loading

Issue Addressed

Addresses #5204.

Fix for the breaking change released in 4.1.2.

@jimmygchen jimmygchen added the ready-for-review The code is ready for review label Feb 7, 2024
@jimmygchen jimmygchen changed the title Remove curve25519-dalek patch Remove curve25519-dalek patch Feb 7, 2024
@jimmygchen jimmygchen added dependencies Pull requests that update a dependency file v5.0.0 Q1 2024 labels Feb 7, 2024
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024 and removed ready-for-review The code is ready for review v5.0.0 Q1 2024 labels Feb 8, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link

mergify bot commented Feb 8, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Feb 8, 2024
@mergify
Merge of #5214
ee50c17
@mergify mergify bot mentioned this pull request Feb 8, 2024
Closed
5 tasks
@realbigsean
Copy link
Member

realbigsean commented Feb 8, 2024 •
edited
Loading

@Mergifyio requeue

@mergify Mergify
Copy link

mergify bot commented Feb 8, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify Mergify
Copy link

mergify bot commented Feb 8, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4b19eac

mergify bot added a commit that referenced this pull request Feb 8, 2024
@mergify
Merge of #5214
7412e13
This was referenced Feb 8, 2024
Closed
Merged
@mergify mergify bot merged commit 4b19eac into sigp:unstable Feb 8, 2024
29 checks passed
danielrachi1 pushed a commit to danielrachi1/lighthouse that referenced this pull request Feb 14, 2024
@jimmygchen @danielrachi1
Remove curve25519-dalek patch (sigp#5214)
c4c4d2e 
* Remove patch dependencies
@paulhauner paulhauner mentioned this pull request Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge. v5.0.0 Q1 2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmygchen @michaelsproul @realbigsean