Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ethers core #5301

Merged
merged 21 commits into from
Jul 24, 2024
Merged

Conversation

dospore
Copy link
Contributor

@dospore dospore commented Feb 26, 2024

Issue Addressed

Working from #5207 to begin conversion from ethers_core to alloy

Proposed Changes

Uses alloy RlpEncodable/RlpDecodable types instead of ethers_core rlp stream

Additional Info

There are many more uses of ethers_core in this repository so thought I would reduce the number of changes and potentially put more pr's in the future.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2024

CLA assistant check
All committers have signed the CLA.

@dapplion dapplion added the work-in-progress PR is a work-in-progress label Feb 27, 2024
@dapplion
Copy link
Collaborator

@dospore sorry for leaving this PR open for a while, would you mind fixing conflicts?

@michaelsproul michaelsproul added code-quality dependencies Pull requests that update a dependency file labels Jul 1, 2024
@dospore
Copy link
Contributor Author

dospore commented Jul 3, 2024

@dospore sorry for leaving this PR open for a while, would you mind fixing conflicts?

Yes, for sure. Ill get around this tomorrow @dapplion

@dapplion dapplion requested review from ethDreamer, realbigsean and michaelsproul and removed request for realbigsean July 10, 2024 09:03
@dapplion
Copy link
Collaborator

error: package `migrations_macros v2.2.0` cannot be built because it requires rustc 1.78.0 or newer, while the currently active rustc version is 1.77.0
Either upgrade to rustc 1.78.0 or newer, or use
cargo update migrations_macros@2.2.0 --precise ver
where `ver` is the latest version of `migrations_macros` supporting rustc 1.77.0

Is it necessary to bump diesel_migrations?

@dospore
Copy link
Contributor Author

dospore commented Jul 14, 2024

Is it necessary to bump diesel_migrations?
Yeah im not sure what happened there. Looks like my lock file got muddled up, pulled in unstable and is succeeding in running that check on 1.77.0 locally

@michaelsproul michaelsproul added ready-for-review The code is ready for review v5.3.0 Q3 2024 release with database changes! and removed work-in-progress PR is a work-in-progress labels Jul 23, 2024
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Jul 24, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jul 24, 2024
mergify bot added a commit that referenced this pull request Jul 24, 2024
@michaelsproul
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Jul 24, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Jul 24, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 10445f3

mergify bot added a commit that referenced this pull request Jul 24, 2024
@mergify mergify bot merged commit 10445f3 into sigp:unstable Jul 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality dependencies Pull requests that update a dependency file ready-for-merge This PR is ready to merge. v5.3.0 Q3 2024 release with database changes!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants