Improve logging around peer scoring #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgeManning
added
ready-for-review
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f919f82 |
5 tasks
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Mar 5, 2024
* Improve logging around score states * Improve logs also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some very reasonable confusion around some of the lighthouse logs around our peer scoring.
The main reason for this confusion is that there are two peer states with the same name. A connection state: disconnected and a score state: disconnected.
This PR renames the score state to: ForcedDisconnect to remove this confusion and improves the logging around these states.