Downgrade rate limited log #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Mar 8, 2024
| | Protocol::BlobsByRange | ||
| | Protocol::BlocksByRoot | ||
| | Protocol::BlobsByRoot | ||
| ) { |
There was a problem hiding this comment.
The log below need to be updated too - remove "By range", and may be worth mentioning that request is too large
jimmygchen
added
waiting-on-author
pawanjay176
force-pushed
the
downgrade-log
branch
from
84f8a62
to
907dc34
Compare
pawanjay176
added
ready-for-review
AgeManning
approved these changes
Mar 10, 2024
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 54b1c22 |
Merged
danielrachi1
pushed a commit
to danielrachi1/lighthouse
that referenced
this pull request
Mar 12, 2024
* Address review comments * Downgrade log for by_root requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Downgrade rate limited logs for all protocols where the expected responses > 1
This is not really an issue but we are seeing a few caplin peers on sepolia that are sending us a lot of blobroot requests, so this might happen on other networks too which might lead to a lot of users asking us about it on discord