Move gossipsub into a separate crate

[jxs]

Issue Addressed

this will helps us better track changes into the Gossipsub protocol into different versions and a proper CHANGELOG.md file.
Eventually we can also release it as a separate crate.

This PR also probably addresses #5389 cc @pawanjay176

[AgeManning]

The changes look good.

I think (if it's possible) it might be better to put it inside the lighthouse_network dir as it seems to be the best place logically for it. Avoid the consensus people getting too scared with seeing it inside beacon_node 😅

[jxs]

The changes look good.

I think (if it's possible) it might be better to put it inside the lighthouse_network dir as it seems to be the best place logically for it. Avoid the consensus people getting too scared with seeing it inside beacon_node 😅

yeah I thought of that, but unfortunately it's not possible as lighthouse_network is a crate by itself

[AgeManning]

Oh. Isn't beacon_node itself also a crate?

Or another example is the validator_client :https://github.com/sigp/lighthouse/blob/stable/validator_client/Cargo.toml
which also has slashing_protection inside its directory.

These looked similar to lighthouse_network, does cargo throw an error if we try?

[jxs]

Oh. Isn't beacon_node itself also a crate?

Or another example is the validator_client >:https://github.com/sigp/lighthouse/blob/stable/validator_client/Cargo.toml
which also has slashing_protection inside its directory.

These looked similar to lighthouse_network, does cargo throw an error if we try?

Right, thanks for pushing this age, it's actually possible. I naively assumed that it wasn't as I didn't see any other example on the workspace, but it's perfectly fine. Updated!

[AgeManning]

Oh nice. I think this structure is better.

Should we put the CHANGELOG inside gossipsub tho?

[ackintosh]

I think the features section can be removed.

Suggested change

	libp2p = { version = "0.53", default-features = false, features = ["identify", "yamux", "noise", "dns", "tcp", "tokio", "plaintext", "secp256k1", "macros", "ecdsa", "metrics", "quic", "upnp"]}
	libp2p = { version = "0.53", default-features = false }

[jxs]

thanks Akihito, updated!

[ackintosh]

Regarding to logging, we need to change the target name from libp2p_gossipsub to gossipsub so that the gossipsub logs are correctly written to a file. This change will resolve #5389. 💡

lighthouse/common/logging/src/tracing_logging_layer.rs

Lines 29 to 33 in 612eaf2

	let mut writer = match target {
	"libp2p_gossipsub" => self.libp2p_non_blocking_writer.clone(),
	"discv5" => self.discv5_non_blocking_writer.clone(),
	_ => return,
	};

[AgeManning]

@Mergifyio queue

[mergify]

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 59ef564